[Editor][Typing] Fixing missing types in perseus-editor/src/components#3448
Merged
catandthemachines merged 15 commits intomainfrom Apr 6, 2026
Merged
[Editor][Typing] Fixing missing types in perseus-editor/src/components#3448catandthemachines merged 15 commits intomainfrom
catandthemachines merged 15 commits intomainfrom
Conversation
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +20 B (0%) Total Size: 495 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (086df74) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3448If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3448If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3448 |
…ds to components folder in perseus-editor.
Member
Author
|
@claude review once |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Member
Author
|
@claude review once |
jeremywiebe
approved these changes
Apr 2, 2026
…spread all the graph properties.
…he interaction-editor.
Merged
mark-fitzgerald
pushed a commit
that referenced
this pull request
Apr 7, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#3273](#3273) [`1f532f29c0`](1f532f2) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Radio] Merge top-level widget files into one, and refactor to remove legacy code ### Patch Changes - [#3457](#3457) [`9578d5a1ae`](9578d5a) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Sync dependencies with Frontend - [#3417](#3417) [`732cfab8fc`](732cfab) Thanks [@jandrade](https://github.com/jandrade)! - Updates WB typography instances to use `Heading` and `BodyText`. - Updated dependencies \[[`9578d5a1ae`](9578d5a)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#3457](#3457) [`9578d5a1ae`](9578d5a) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Sync dependencies with Frontend ## @khanacademy/[email protected] ### Patch Changes - [#3457](#3457) [`9578d5a1ae`](9578d5a) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Sync dependencies with Frontend - [#3448](#3448) [`0e30752302`](0e30752) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Adding improved type safeguards to components folder in perseus-editor. - Updated dependencies \[[`9578d5a1ae`](9578d5a), [`1f532f29c0`](1f532f2), [`732cfab8fc`](732cfab)]: - @khanacademy/[email protected] - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: claude[bot], mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ✅ 6 checks were successful, ⏭️ 2 checks have been skipped Pull Request URL: #3453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adding missing types to perseus-editor/src/components folder. This is important to minimize regressions and create a more stable editor experiences.
I also moved the associated stories for components back into the proper folder type so it now appears in our Storybook again.
Issue: LEMS-2748
Test plan:
Run
pnpm testAnd because this is old legacy code, will create a ZND and test this in our editor to double check no glaring type issues.
ZND PR: https://github.com/Khan/frontend/pull/9938